From 05403599ae07ba727b98e0f0acf9bae8b1051f51 Mon Sep 17 00:00:00 2001 From: Uwe Rathmann Date: Fri, 3 Jan 2020 11:40:57 +0100 Subject: [PATCH] minor performance improvements --- src/common/QskGradient.cpp | 25 ++++++++----------------- src/common/QskGradient.h | 11 +++++++++++ 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/src/common/QskGradient.cpp b/src/common/QskGradient.cpp index a3f319e6..a27fb931 100644 --- a/src/common/QskGradient.cpp +++ b/src/common/QskGradient.cpp @@ -110,17 +110,6 @@ static inline QVector< QskGradientStop > qskExpandedStops( return stops; } -QskGradientStop::QskGradientStop() - : m_position( -1.0 ) -{ -} - -QskGradientStop::QskGradientStop( qreal position, const QColor& color ) - : m_position( position ) - , m_color( color ) -{ -} - void QskGradientStop::setPosition( qreal position ) { m_position = position; @@ -249,16 +238,18 @@ QskGradient::Orientation QskGradient::orientation() const void QskGradient::setColor( const QColor& color ) { - setColors( color, color ); + m_stops.reserve( 2 ); + + m_stops.append( QskGradientStop( 0.0, color ) ); + m_stops.append( QskGradientStop( 1.0, color ) ); } void QskGradient::setColors( const QColor& startColor, const QColor& stopColor ) { - m_stops.resize( 2 ); - m_stops[ 0 ].setPosition( 0.0 ); - m_stops[ 0 ].setColor( startColor ); - m_stops[ 1 ].setPosition( 1.0 ); - m_stops[ 1 ].setColor( stopColor ); + m_stops.reserve( 2 ); + + m_stops.append( QskGradientStop( 0.0, startColor ) ); + m_stops.append( QskGradientStop( 1.0, stopColor ) ); } void QskGradient::setStops( const QVector< QskGradientStop >& stops ) diff --git a/src/common/QskGradient.h b/src/common/QskGradient.h index 95222fa7..e66d169f 100644 --- a/src/common/QskGradient.h +++ b/src/common/QskGradient.h @@ -145,6 +145,17 @@ inline QColor QskGradient::endColor() const return ( m_stops.size() >= 2 ) ? m_stops.last().color() : QColor(); } +inline QskGradientStop::QskGradientStop() + : m_position( -1.0 ) +{ +} + +inline QskGradientStop::QskGradientStop( qreal position, const QColor& color ) + : m_position( position ) + , m_color( color ) +{ +} + inline qreal QskGradientStop::position() const { return m_position;