peranger/qskinny
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

virtual keyboard: Fix out of bounds access

Browse Source 
The user can modify the keyboard rows and cols, so we should not rely
on hardcoded values.
This commit is contained in:
Peter Hartmann 2023-04-12 10:36:42 +02:00 committed by uwerat
parent 45a1bc3564
commit 019e867d10
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/inputpanel/QskVirtualKeyboard.cpp
View File

@ -434,9 +434,11 @@ void QskVirtualKeyboard::updateKeyCodes()
m_data->keyCodes = {}; m_data->keyCodes = {};
m_data->keyCodes.reserve( rowCount() * columnCount() ); m_data->keyCodes.reserve( rowCount() * columnCount() );
for ( int mode = 0; mode < ModeCount; mode++ ) const auto layout = *m_data->currentLayout;
for ( int mode = 0; mode < layout.size(); mode++ )
{ {
const auto& page = ( *m_data->currentLayout )[ mode ]; const auto& page = layout[ mode ];
for ( int i = 0; i < page.size(); i++ ) for ( int i = 0; i < page.size(); i++ )
{ {